linux-kernel - Re: [PATCH v3 01/11] dt-bindings: clock: Add Actions S900 clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 10 Feb 2018 13:32:54 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Philippe Ombredanne <pombredanne@...b.com>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Andreas Färber <afaerber@...e.de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, liuwei@...ions-semi.com,
        mp-cs@...ions-semi.com, 96boards@...obotics.com,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Amit Kucheria <amit.kucheria@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>, linux-clk@...r.kernel.org,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        Viresh Kumar <viresh.kumar@...aro.org>
Subject: Re: [PATCH v3 01/11] dt-bindings: clock: Add Actions S900 clock bindings

Hi Philippe,

On 10 February 2018 at 13:06, Philippe Ombredanne <pombredanne@...b.com> wrote:
> Dear Manivannan,
>
> On Sat, Feb 10, 2018 at 3:41 AM, Manivannan Sadhasivam
> <manivannan.sadhasivam@...aro.org> wrote:
>> Add Actions Semi S900 clock bindings.
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>> Acked-by: Rob Herring <robh@...nel.org>
>
> <snip>
>
>> diff --git a/include/dt-bindings/clock/actions,s900-cmu.h b/include/dt-bindings/clock/actions,s900-cmu.h
>> new file mode 100644
>> index 000000000000..2fa94e19922b
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/actions,s900-cmu.h
>> @@ -0,0 +1,139 @@
>> +/*
>> + * Device Tree binding constants for Actions S900 Clock Management Unit
>> + *
>> + * Copyright (c) 2014 Actions Semi Inc.
>> + * Copyright (c) 2017 Linaro Ltd.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + */
>
> Would you consider using the new SPDX license ids rather that this
> time-tested but rather boring legalese?
>

Very sorry! I converted all the driver code to SPDX license tag but since
this file was already Acked, I forgot to do so.

Will clean it up.

> The (still new and fresh) license documentation contributed by tglx
> --the only maintainer that I know that understands both the innards of
> Spectre and Meltdown and the beauty of reStructuredText -- is in:
> Documentation/process/license-rules.rst
>
> Practically this means replacing the above by a simple single line and
> getting rid of a whopping 8 comment lines!
>
> SPDX-License-Identifier: GPL-2.0+
>
> You get to save a few tree as a bonus if you also do the same for all
> Linaro-copyrighted files. Yes this is saving trees because I will use
> less paper each time I print a listing of the kernel source code.
> Which is something that I rarely if ever do: but somebody must do it
> somewhere for sure.
>

This is something I will consider doing it in a separate patchset.

> If I do the math: we have ~60K files in the kernel, and say we can
> remove roughly 5 lines of legalese per file on average. Each printed
> source code page is roughly 60 lines : this will mean a saving of
> about 6000 paper sheets saved on each printout! A letter-size paper
> ream is 500 pages, about 2.5 Kg and costs about ~$8.  You can extract
> about 10K to 20k sheets of paper per tree [1].
> Therefore my Fermi estimate is that using shorter legalese in the
> kernel will eventually save roughly ONE FULL smaller tree (6K pages)
> each time someone prints the kernel code: incredible, right?
>
> Thank  you for helping make the kernel a mostly legalese-free codebase
> and saving trees at the same time!
>

Thanks for the finding!

Regards,
Mani

> [1] https://www.sierraclub.org/sierra/2014-4-july-august/green-life/how-much-paper-does-one-tree-produce
> --
> Cordially
> Philippe Ombredanne