linux-kernel - Re: [PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Feb 2018 12:08:23 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        linux-gpio@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] gpio: merrifield: Delete an error message for a failed
 memory allocation in mrfld_gpio_probe()

On Sun, 2018-02-11 at 13:42 +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 11 Feb 2018 13:30:14 +0100
> 
> Omit an extra message for a memory allocation failure in this
> function.
> 
> This issue was detected by using the Coccinelle software.
> 

Linus, I have no strong opinion here, so, up to you to decide.

If you decide this patch to go, 

Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>


> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/gpio/gpio-merrifield.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio-
> merrifield.c
> index dd67a31ac337..eec21122299e 100644
> --- a/drivers/gpio/gpio-merrifield.c
> +++ b/drivers/gpio/gpio-merrifield.c
> @@ -408,10 +408,8 @@ static int mrfld_gpio_probe(struct pci_dev *pdev,
> const struct pci_device_id *id
>  	pcim_iounmap_regions(pdev, BIT(1));
>  
>  	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> -	if (!priv) {
> -		dev_err(&pdev->dev, "can't allocate chip data\n");
> +	if (!priv)
>  		return -ENOMEM;
> -	}
>  
>  	priv->dev = &pdev->dev;
>  	priv->reg_base = pcim_iomap_table(pdev)[0];

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy