linux-kernel - Re: [PATCH v2] auxdisplay: img-ascii-lcd: kconfig: Remove MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Feb 2018 14:51:49 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Ulf Magnusson <ulfalizer@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-kbuild@...r.kernel.org, tfiga@...omium.org,
        paul.burton@...s.com, Marek Szyprowski <m.szyprowski@...sung.com>,
        Hans-Christian Noren Egtvedt <egtvedt@...fundet.no>,
        Linus Walleij <linus.walleij@...aro.org>, vgupta@...opsys.com,
        mgorman@...hsingularity.net, hch@....de, mina86@...a86.com,
        robh@...nel.org, sboyd@...eaurora.org, paulus@...abs.org,
        will.deacon@....com, Tony Lindgren <tony@...mide.com>,
        npiggin@...il.com, yamada.masahiro@...ionext.com
Subject: Re: [PATCH v2] auxdisplay: img-ascii-lcd: kconfig: Remove MIPS_SEAD3 reference

On Sun, Feb 11, 2018 at 5:40 PM, Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
> On Sat, Feb 10, 2018 at 3:14 PM, Ulf Magnusson <ulfalizer@...il.com> wrote:
>> Commit 3f5f0a4475e1 ("MIPS: generic: Convert SEAD-3 to a generic board")
>> removed the MIPS_SEAD3 symbol and moved the setting of IMG_ASCII_LCD to
>> the board-sead-3.config defconfig file, but IMG_ASCII_LCD still
>> references the removed MIPS_SEAD3 symbol.
>>
>> Remove the reference.
>>
>> Discovered with the
>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> script.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
>> ---
>> Changes in v2:
>>
>>  - The wrong commit was referenced in the commit message.
>>
>>  - Mention that IMG_ASCII_LCD is now set via the board-sead-3.config defconfig
>>    file.
>>
>>  - Clarify that Kconfig is involved. The previous commit title was
>>    "auxdisplay: img-ascii-lcd: Remove MIPS_SEAD3 reference".
>>
>
> Thanks for the new version!
>
> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>

To clarify, I am picking this patch up for my queue (sorry for any confusion!).

>
>>
>>  drivers/auxdisplay/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
>> index 2c2ed9cf8796..3cba78d36eec 100644
>> --- a/drivers/auxdisplay/Kconfig
>> +++ b/drivers/auxdisplay/Kconfig
>> @@ -137,7 +137,7 @@ config CFAG12864B_RATE
>>  config IMG_ASCII_LCD
>>         tristate "Imagination Technologies ASCII LCD Display"
>>         depends on HAS_IOMEM
>> -       default y if MIPS_MALTA || MIPS_SEAD3
>> +       default y if MIPS_MALTA
>>         select SYSCON
>>         help
>>           Enable this to support the simple ASCII LCD displays found on
>> --
>> 2.14.1
>>