linux-kernel - Re: why scripts/link-vmlinux.sh has a final build of init/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Feb 2018 23:48:48 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Cao jin <caoj.fnst@...fujitsu.com>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: why scripts/link-vmlinux.sh has a final build of init/

2018-02-12 13:22 GMT+09:00 Cao jin <caoj.fnst@...fujitsu.com>:
> Hi Masahiro-san,
>
>   As I remember, init/ is already built during recursive make, and I did
> a clean build(make mrproper, make localmodconfig) with all plugins
> included on x86_64 with following patch, the kernel can boot without any
> obvious problem. So, I don't figure out why we need this final build?
>
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index e6818b8e7141..086b2efd4d53 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -247,9 +247,6 @@ else
>         expr 0$(cat .old_version) + 1 >.version;
>  fi;
>
> -# final build of init/
> -${MAKE} -f "${srctree}/scripts/Makefile.build" obj=init
> GCC_PLUGINS_CFLAGS="${GCC_PLUGINS_CFLAGS}"
> -
>  archive_builtin
>
>  #link vmlinux.o
>


link-vmlinux.sh increments '.version'
so it must descend into init/
to update include/generated/compile.h
and re-compile init/version.o

We do not increment '.version'
at the first descend into init/
because we never know whether the kernel
is updated or not before the final link stage.


-- 
Best Regards
Masahiro Yamada