linux-kernel - Re: [PATCH v2 01/12] ARM: dts: STi: Fix bindings notation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Feb 2018 09:19:35 -0600
From:   Rob Herring <robh@...nel.org>
To:     patrice.chotard@...com
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux@...linux.org.uk,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 01/12] ARM: dts: STi: Fix bindings notation

On Mon, Feb 12, 2018 at 8:42 AM,  <patrice.chotard@...com> wrote:
> From: Patrice Chotard <patrice.chotard@...com>
>
> Remove leading 0x and 0s from bindings notation
> Add missing unit-address and remove some which are useless.
>
> This allows to fix several warnings like :
>
> Warning (unit_address_vs_reg): Node XXXX has a reg or ranges property, but no unit name
> Warning (simple_bus_reg): Node XXXX simple-bus unit address format error, expected "123456"
> Warning (unit_address_vs_reg): Node XXXX has a unit name, but no reg property
>
> Signed-off-by: Patrice Chotard <patrice.chotard@...com>
> ---

[...]

> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index a29090077fdf..53c6888d1fc0 100644
> --- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> @@ -45,7 +45,7 @@
>         };
>
>         soc {
> -               pin-controller-sbc {
> +               pin-controller-sbc@...f080 {

While you're here changing the node name, these all should be "pinctrl@..."

With that,

Reviewed-by: Rob Herring <robh@...nel.org>