linux-kernel - [PATCH] dmaengine: at_xdmac: Delete an error message for a failed memory allocation in at_xdmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 13 Feb 2018 21:54:03 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Dan Williams <dan.j.williams@...el.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Vinod Koul <vinod.koul@...el.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH] dmaengine: at_xdmac: Delete an error message for a failed
 memory allocation in at_xdmac_probe()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Tue, 13 Feb 2018 21:48:26 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/dma/at_xdmac.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index c00e3923d7d8..818ab96f9601 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -1950,10 +1950,8 @@ static int at_xdmac_probe(struct platform_device *pdev)
 	size = sizeof(*atxdmac);
 	size += nr_channels * sizeof(struct at_xdmac_chan);
 	atxdmac = devm_kzalloc(&pdev->dev, size, GFP_KERNEL);
-	if (!atxdmac) {
-		dev_err(&pdev->dev, "can't allocate at_xdmac structure\n");
+	if (!atxdmac)
 		return -ENOMEM;
-	}
 
 	atxdmac->regs = base;
 	atxdmac->irq = irq;
-- 
2.16.1