lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Feb 2018 14:24:56 -0500 From: "Hook, Gary" <ghook@....com> To: Joerg Roedel <joro@...tes.org> Cc: Gary R Hook <gary.hook@....com>, iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] iommu/amd - Use dev_err to send events to the system log On 2/13/2018 11:00 AM, Joerg Roedel wrote: > On Tue, Feb 13, 2018 at 10:47:55AM -0500, Hook, Gary wrote: >> >> dev_err(&iommu->dev->dev, "ILLEGAL... > > I think its more something like iommu->iommu->dev. > > Without actually running a driver and getting some debug info, I'll just say that my example compiled, the amd_iommu structure points to a pci_dev which contains a device, and the two possibilities are likely equivalent. I'll vet that, of course, but working under the assumption that they are equivalent, the question becomes, do you have a preference? Thanks, Gary
Powered by blists - more mailing lists