lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Feb 2018 14:52:23 +0900 From: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> To: Mike Rapoport <rppt@...ux.vnet.ibm.com> Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>, Minchan Kim <minchan@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, linux-mm@...ck.org, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> Subject: Re: [PATCHv2 1/2] zsmalloc: introduce zs_huge_object() function On (02/11/18 09:05), Mike Rapoport wrote: [..] > > +/** > > + * zs_huge_object() - Test if a compressed object's size is too big for normal > > + * zspool classes and it shall be stored in a huge class. > > I think "is should be stored" is more appropriate > > > + * @sz: Size of the compressed object (in bytes). > > + * > > + * The function checks if the object's size falls into huge_class > > + * area. We must take handle size into account and test the actual > > + * size we are going to use, because zs_malloc() unconditionally > > + * adds %ZS_HANDLE_SIZE before it performs %size_class lookup. > > ^ &size_class ;-) I'm sorry, Mike. Lost in branches/versions and sent out a half baked version. -ss
Powered by blists - more mailing lists