linux-kernel - Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Feb 2018 22:35:04 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Cosmin-Gabriel Samoila <cosmin.samoila@....com>
Cc:     Mark <broonie@...nel.org>, ALSA <alsa-devel@...a-project.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Rob Herring <robh@...nel.org>,
        mihai.serban@...il.com, linux-imx@....com, shegjiu.wang@....com,
        daniel.baluta@....com, LKML <linux-kernel@...r.kernel.org>,
        Junichi Wakasugi <wakasugi.jb@...asahi-kasei.co.jp>,
        Mihai Serban <mihai.serban@....com>,
        Shengjiu Wang <shengjiu.wang@....com>
Subject: Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

On Wed, Feb 14, 2018 at 2:21 PM, Cosmin-Gabriel Samoila
<cosmin.samoila@....com> wrote:
> The AK4458 is a 32-bit 8ch Premium DAC that corresponds
> to a 768kHz PCM input and an 11.2MHz DSD input at maximum.
> It supports I2S, DSD and TDM modes with 24 or 32 bit MSB
> or 16, 24, 32 LSB formats. Its datasheet is available here:
> https://www.akm.com/akm/en/file/datasheet/AK4458VN.pdf
>
> Signed-off-by: Junichi Wakasugi <wakasugi.jb@...asahi-kasei.co.jp>
> Signed-off-by: Mihai Serban <mihai.serban@....com>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> Signed-off-by: Cosmin-Gabriel Samoila <cosmin.samoila@....com>
> ---

> --- /dev/null
> +++ b/sound/soc/codecs/ak4458.c
> @@ -0,0 +1,659 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Audio driver for AK4458 DAC
> + *
> + * Copyright (C) 2016 Asahi Kasei Microdevices Corporation
> + * Copyright 2018 NXP

Thanks for using the proper SPDX tag here.... yet see my comments below.

<snip>

> +MODULE_AUTHOR("Junichi Wakasugi <wakasugi.jb@...asahi-kasei.co.jp>");
> +MODULE_AUTHOR("Mihai Serban <mihai.serban@....com>");
> +MODULE_DESCRIPTION("ASoC AK4458 DAC driver");
> +MODULE_LICENSE("GPL");

This means GPL-2.0+ per module.h and therefore does not match your
GPL-2.0 SPDX tag above.
Go one way or the other, but not both way please.

> diff --git a/sound/soc/codecs/ak4458.h b/sound/soc/codecs/ak4458.h
> new file mode 100644
> index 0000000..16d9d22
> --- /dev/null
> +++ b/sound/soc/codecs/ak4458.h
> @@ -0,0 +1,86 @@
> +// SPDX-License-Identifier: GPL-2.0

As weird as it sounds the style should be plain /*
SPDX-License-Identifier: GPL-2.0 /* here per [1]

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne