linux-kernel - Re: [RFC PATCH 2/3] fixup! audit: remove arch_f pointer from struct audit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Feb 2018 15:43:49 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     Richard Guy Briggs <rgb@...hat.com>
Cc:     Linux-Audit Mailing List <linux-audit@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Eric Paris <eparis@...hat.com>, Steve Grubb <sgrubb@...hat.com>
Subject: Re: [RFC PATCH 2/3] fixup! audit: remove arch_f pointer from struct audit_krule

On Mon, Feb 12, 2018 at 7:29 AM, Richard Guy Briggs <rgb@...hat.com> wrote:
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> ---
>  kernel/auditfilter.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

I realize this is an RFC patchset, but considering recent patchsets I
feel some clarification might be helpful to prevent future delays ...
when submitting patchsets for merging please do not submit "fixup!"
patches which fix problems in patches that are submitted earlier in
the patchset, simply merge/squash the "fixup!" patches before
submitting.

> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index 3343d1c..48dcb59 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -221,11 +221,13 @@ static inline int audit_match_class_bits(int class, u32 *mask)
>  static int audit_match_signal(struct audit_entry *entry)
>  {
>         int i;
> +       u32 archval;
>         struct audit_field *arch;
>
>         for (i = 0; i < entry->rule.field_count; i++)
>                 if (entry->rule.fields[i].type == AUDIT_ARCH) {
>                         arch = &entry->rule.fields[i];
> +                       archval = arch->val;
>                         break;
>                 }
>
> @@ -238,7 +240,7 @@ static int audit_match_signal(struct audit_entry *entry)
>                                                entry->rule.mask));
>         }
>
> -       switch(audit_classify_arch(arch->val)) {
> +       switch(audit_classify_arch(archval)) {
>         case 0: /* native */
>                 return (audit_match_class_bits(AUDIT_CLASS_SIGNAL,
>                                                entry->rule.mask));
> --
> 1.8.3.1
>



-- 
paul moore
www.paul-moore.com