linux-kernel - linux-next: build failure after merge of the mmc tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Feb 2018 11:49:54 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kishon Vijay Abraham I <kishon@...com>
Subject: linux-next: build failure after merge of the mmc tree

Hi Ulf,

After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_set_timing':
drivers/mmc/host/sdhci-omap.c:466:8: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'inc_node_state'? [-Werror=implicit-function-declaration]
  ret = pinctrl_select_state(omap_host->pinctrl, pinctrl_state);
        ^~~~~~~~~~~~~~~~~~~~
        inc_node_state
drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_iodelay_pinctrl_state':
drivers/mmc/host/sdhci-omap.c:740:18: error: implicit declaration of function 'pinctrl_lookup_state'; did you mean 'inc_node_state'? [-Werror=implicit-function-declaration]
  pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
                  ^~~~~~~~~~~~~~~~~~~~
                  inc_node_state
drivers/mmc/host/sdhci-omap.c:740:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
                ^
drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_config_iodelay_pinctrl_state':
drivers/mmc/host/sdhci-omap.c:769:23: error: implicit declaration of function 'devm_pinctrl_get'; did you mean 'devm_clk_get'? [-Werror=implicit-function-declaration]
  omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
                       ^~~~~~~~~~~~~~~~
                       devm_clk_get
drivers/mmc/host/sdhci-omap.c:769:21: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
                     ^
drivers/mmc/host/sdhci-omap.c:775:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  state = pinctrl_lookup_state(omap_host->pinctrl, "default");
        ^

Caused by commit

  713190bb14aa ("mmc: sdhci_omap: Add support to set IODELAY values")

Forgot to include linux/pinctrl/consumer.h?

I have used the mmc tree from next-20180214 for today.

-- 
Cheers,
Stephen Rothwell