linux-kernel - Re: [PATCH v3 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed with rk3399 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Feb 2018 17:33:48 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Caesar Wang <wxt@...k-chips.com>
CC:     Brian Norris <briannorris@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        <linux-rockchip@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, Heiko Stuebner <heiko@...ech.de>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed
 with rk3399 SoCs



On Thursday 11 January 2018 08:10 AM, Caesar Wang wrote:
> Hi Kishon,
> 
> Since the Shawn isn't available, I take over this series patches for now.
> 
> As the original bug had tracked on https://issuetracker.google.com/71561742.
> In some cases, the mmc phy power on failed during booting up.
> The log as below:
> ...
> [   2.375333] rockchip_emmc_phy_power: caldone timeout.
> [    2.377815] phy phy-ff770000.syscon:phy@...0.4: phy poweron failed --> -110
> ...
> [    2.489295] mmc0: mmc_select_hs400es failed, error -110
> [    2.489302] mmc0: error -110 whilst initialising MMC card
> ..
> 
> The actual emulate, the wait 5us for calpad busy trimming, that's no enough.
> We need give the enough margin for it.
> 
> Verified on url =
>         https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.4
> This series patches can apply and bring up with kernel-next on rk3399 chromebook.

merged now, thanks!

-Kishon
> 
> -Caesar
> 
> 
> Changes in v3:
> - As Doug commented on both upstream and gerrit.
>   Change "5, 50" to "0, 50", and the message of print.
> - As Doug commented on https://patchwork.kernel.org/patch/10154797,
>   Change "1, 50" to "0, 50".
> 
> Changes in v2:
> - print the return valut with regmap_read_poll_timeout failing.
> - As Brian commented on https://patchwork.kernel.org/patch/10139891/,
>   changed the note and added to print error value with
>   regmap_read_poll_timeout API.
> 
> Shawn Lin (2):
>   phy: rockchip-emmc: retry calpad busy trimming
>   phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy
> 
>  drivers/phy/rockchip/phy-rockchip-emmc.c | 60 +++++++++++++++-----------------
>  1 file changed, 28 insertions(+), 32 deletions(-)
>