lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 16 Feb 2018 15:36:06 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yash Omer <yashomer0007@...il.com>
Cc:     devel@...verdev.osuosl.org, driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [PATCH] Staging: wlan-ng: Fix Alignment should match open
 paranthesis in prism2mgmt.c

On Fri, Feb 16, 2018 at 12:18:36AM +0530, Yash Omer wrote:
> This is patch fixes up a matching paranthesis alignment issue found by checkpatch.pl script.
> 
> Signed-off-by: Yash Omer <yashomer0007@...il.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index 5be1af20d2d4..974a7572fafc 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -264,8 +264,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
>  			goto exit;
>  		}
>  		/* ibss options */
> -		result = hfa384x_drvr_setconfig16(hw,
> -					HFA384x_RID_CREATEIBSS,
> +		result = hfa384x_drvr_setconfig16
> +					(hw, HFA384x_RID_CREATEIBSS,

The original code is just fine, why is checkpatch complaining about
this?

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ