linux-kernel - Re: [PATCH] extable: Make init_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Feb 2018 13:03:50 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Jason Baron <jbaron@...mai.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Borislav Petkov <bp@...e.de>
Subject: Re: [PATCH] extable: Make init_kernel_text() global

On Fri, 16 Feb 2018 11:57:44 -0600
Josh Poimboeuf <jpoimboe@...hat.com> wrote:

> On Fri, Feb 16, 2018 at 11:55:54AM -0500, Jason Baron wrote:
> > > +/* Disable any jump label entries in __init code */
> > > +void __init jump_label_invalidate_init(void)
> > > +{
> > > +	struct jump_entry *iter_start = __start___jump_table;
> > > +	struct jump_entry *iter_stop = __stop___jump_table;
> > > +	struct jump_entry *iter;
> > > +
> > > +	for (iter = iter_start; iter < iter_stop; iter++)
> > > +		if (iter->code >= (unsigned long)_sinittext &&
> > > +		    iter->code < (unsigned long)_einittext)
> > > +			iter->code = 0;
> > > +}  
> > 
> > Seems like this wants to use init_kernel_text() but i see its marked
> > 'static', perhaps it can be moved to a header?  
> 
> How about this patch on top?

Yes please.

> 
> ---------
> 
> From: Josh Poimboeuf <jpoimboe@...hat.com>
> Subject: [PATCH] extable: Make init_kernel_text() global
> 
> Convert init_kernel_text() to a global function and use it in a few
> places instead of manually comparing _sinittext and _einittext.
> 
> Note that kallsyms.h has a very similar function called
> is_kernel_inittext(), but its end check is inclusive.  I'm not sure
> whether that's intentional behavior, so I didn't touch it.
> 
> Suggested-by: Jason Baron <jbaron@...mai.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> ---

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve