linux-kernel - Re: [PATCH v4] rtc: isl12026: Add driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Feb 2018 13:19:22 -0800
From:   David Daney <ddaney@...iumnetworks.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        David Daney <david.daney@...ium.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux-rtc@...r.kernel.org,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] rtc: isl12026: Add driver.

On 02/16/2018 12:13 PM, Andy Shevchenko wrote:
> On Fri, Feb 16, 2018 at 9:44 PM, David Daney <david.daney@...ium.com> wrote:
>> The ISL12026 is a combination RTC and EEPROM device with I2C
>> interface.  The standard RTC driver interface is provided.  The EEPROM
>> is accessed via the NVMEM interface via the "eeprom0" directory in the
>> sysfs entry for the device.
> 
>> +config RTC_DRV_ISL12026
>> +       tristate "Intersil ISL12026"
> 
> depends on OF

It doesn't depend on CONFIG_OF, it builds just fine without it.

> 
>> +static struct i2c_driver isl12026_driver = {
>> +       .driver         = {
>> +               .name   = "rtc-isl12026",
>> +               .of_match_table = of_match_ptr(isl12026_dt_match),
> 
> /of_match_ptr//


of_match_ptr() needed if we build without CONFIG_OF

> 
>> +       },
>> +       .probe_new      = isl12026_probe_new,
>> +       .remove         = isl12026_remove,
>> +};
>