linux-kernel - Re: [PATCH] md/raid1: Fix trailing semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 17 Feb 2018 12:59:05 -0800
From:   Shaohua Li <shli@...nel.org>
To:     Luis de Bethencourt <luisbg@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>,
        linux-raid@...r.kernel.org
Subject: Re: [PATCH] md/raid1: Fix trailing semicolon

On Wed, Jan 17, 2018 at 01:38:02PM +0000, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@...nel.org>
> ---
> 
> Hi,
> 
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].

applied, thanks!
> 
> Best regards,
> Luis
> 
> 
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
> 
>  drivers/md/raid1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index b2eae332e1a2..f978eddc7a21 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1108,7 +1108,7 @@ static void alloc_behind_master_bio(struct r1bio *r1_bio,
>  
>  	bio_copy_data(behind_bio, bio);
>  skip_copy:
> -	r1_bio->behind_master_bio = behind_bio;;
> +	r1_bio->behind_master_bio = behind_bio;
>  	set_bit(R1BIO_BehindIO, &r1_bio->state);
>  
>  	return;
> -- 
> 2.15.1
>