linux-kernel - Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 14:49:28 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Jernej Skrabec <jernej.skrabec@...l.net>,
        maxime.ripard@...e-electrons.com, wens@...e.org, airlied@...ux.ie,
        robh+dt@...nel.org, mark.rutland@....com, mturquette@...libre.com,
        sboyd@...nel.org, architt@...eaurora.org, a.hajda@...sung.com,
        Laurent.pinchart@...asonboard.com, narmstrong@...libre.com,
        Jose.Abreu@...opsys.com
Cc:     dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-sunxi@...glegroups.com,
        hjc@...k-chips.com, heiko@...ech.de
Subject: Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber
 drvdata

On Wed, 2018-02-14 at 21:08 +0100, Jernej Skrabec wrote:
> dw_hdmi shouldn't set drvdata since some drivers might need to store
> it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi
> instead to store it in drvdata. This way drivers are responsible to
> store and pass structure when needed.
> 
> Idea was taken from the following commit:
> 8242ecbd597d ("drm/bridge/synopsys: stop clobbering drvdata")
> 
> Cc: p.zabel@...gutronix.de
> Cc: narmstrong@...libre.com
> Cc: Laurent.pinchart@...asonboard.com
> Cc: hjc@...k-chips.com
> Cc: heiko@...ech.de
> Acked-by: Neil Armstrong <narmstrong@...libre.com>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@...l.net>

For i.MX:
Tested-by: Philipp Zabel <p.zabel@...gutronix.de>
Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp