linux-kernel - Re: [PATCH 00/10] Add Actions Semi S900 pinctrl and gpio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 23:10:03 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Andreas Färber <afaerber@...e.de>
Cc:     linus.walleij@...aro.org, robh+dt@...nel.org,
        liuwei@...ions-semi.com, mp-cs@...ions-semi.com,
        96boards@...obotics.com, devicetree@...r.kernel.org,
        daniel.thompson@...aro.org, amit.kucheria@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/10] Add Actions Semi S900 pinctrl and gpio support

On Sat, Feb 17, 2018 at 10:19:50PM +0100, Andreas Färber wrote:
> Am 17.02.2018 um 21:44 schrieb Manivannan Sadhasivam:
> > This patchset adds pinctrl and gpio support for Actions Semi S900 SoC.
> > Pinctrl and gpio subsystems share the common set of register range but
> > implemented as individual drivers for making it less complex.
> > 
> > Pinmux functions are only accessible for pin groups while pinconf
> > parameters are available for both pin groups and individual pins.
> > 
> > gpio-line-names has been added for the Bubblegum-96 board matching the
> > 96Boards CE specification v1.0.
> > 
> > Both pinctrl and gpio drivers are verified using the Bubblegum-96 board.
> > 
> > This patchset depends on the clock driver which is still under review:
> > https://lkml.org/lkml/2018/2/9/831
> 
> What this forgets to point out is that I had authored pinctrl and gpio
> drivers for S500, with preparations for S700 and S900, derived from my
> to-be-submitted pinctrl/gpio drivers for RTD1295, while this one was
> developed independently by Mani for S900. Our intention is to align them
> as part of patch review and redo S500 on top of the result.
>

Sorry for not mentioning that (not intentional). So, I'll push out V2 of the
pinctrl and gpio drivers incorporating all review comments. If that looks
good then we can work on adding S500 support on top of it.

Otherwise we can look on integrating S900 pinctrl definitions with your base
driver. Anyway, for making it easier for comparing both drivers, are you going
to submit yours?
> Regards,
> Andreas
> 
> -- 
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html