linux-kernel - Re: [PATCH] cpufreq: qoriq: Delete two error messages for a failed memory allocation in qoriq_cpufreq_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 09:14:43 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-pm@...r.kernel.org, "Rafael J. Wysocki" <rjw@...ysocki.net>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] cpufreq: qoriq: Delete two error messages for a failed
 memory allocation in qoriq_cpufreq_cpu_init()

On 15-02-18, 18:08, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 15 Feb 2018 18:00:37 +0100
> 
> Omit extra messages for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/cpufreq/qoriq-cpufreq.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c
> index 0562761a3dec..ee3e3656485b 100644
> --- a/drivers/cpufreq/qoriq-cpufreq.c
> +++ b/drivers/cpufreq/qoriq-cpufreq.c
> @@ -192,16 +192,12 @@ static int qoriq_cpufreq_cpu_init(struct cpufreq_policy *policy)
>  	count = clk_hw_get_num_parents(hwclk);
>  
>  	data->pclk = kcalloc(count, sizeof(struct clk *), GFP_KERNEL);
> -	if (!data->pclk) {
> -		pr_err("%s: no memory\n", __func__);
> +	if (!data->pclk)
>  		goto err_nomem2;
> -	}
>  
>  	table = kcalloc(count + 1, sizeof(*table), GFP_KERNEL);
> -	if (!table) {
> -		pr_err("%s: no memory\n", __func__);
> +	if (!table)
>  		goto err_pclk;
> -	}
>  
>  	for (i = 0; i < count; i++) {
>  		clk = clk_hw_get_parent_by_index(hwclk, i)->clk;

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh