linux-kernel - Re: [Intel-wired-lan] [PATCH net-queue] e1000e: Fix check_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Feb 2018 17:55:06 -0800
From:   "Neftin, Sasha" <sasha.neftin@...el.com>
To:     Benjamin Poirier <bpoirier@...e.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net-queue] e1000e: Fix check_for_link
 return value with autoneg off.

On 2/19/2018 22:12, Benjamin Poirier wrote:
> When autoneg is off, the .check_for_link callback functions clear the
> get_link_status flag and systematically return a "pseudo-error". This means
> that the link is not detected as up until the next execution of the
> e1000_watchdog_task() 2 seconds later.
> 
> Fixes: 19110cfbb34d ("e1000e: Separate signaling for link check/link up")
> Signed-off-by: Benjamin Poirier <bpoirier@...e.com>
> ---
>   drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 +-
>   drivers/net/ethernet/intel/e1000e/mac.c     | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c
> index 31277d3bb7dc..ff308b05d68c 100644
> --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
> +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
> @@ -1602,7 +1602,7 @@ static s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw)
>   	 * we have already determined whether we have link or not.
>   	 */
>   	if (!mac->autoneg)
> -		return -E1000_ERR_CONFIG;
> +		return 1;
>   
>   	/* Auto-Neg is enabled.  Auto Speed Detection takes care
>   	 * of MAC speed/duplex configuration.  So we only need to
> diff --git a/drivers/net/ethernet/intel/e1000e/mac.c b/drivers/net/ethernet/intel/e1000e/mac.c
> index f457c5703d0c..db735644b312 100644
> --- a/drivers/net/ethernet/intel/e1000e/mac.c
> +++ b/drivers/net/ethernet/intel/e1000e/mac.c
> @@ -450,7 +450,7 @@ s32 e1000e_check_for_copper_link(struct e1000_hw *hw)
>   	 * we have already determined whether we have link or not.
>   	 */
>   	if (!mac->autoneg)
> -		return -E1000_ERR_CONFIG;
> +		return 1;
>   
>   	/* Auto-Neg is enabled.  Auto Speed Detection takes care
>   	 * of MAC speed/duplex configuration.  So we only need to
> 
Acked-by: Sasha Neftin <sasha.neftin@...el.com>