linux-kernel - Re: [PATCH] Staging: gdm724x: hci: Changed camel-case to snake-case.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Feb 2018 03:15:54 -0800
From:   Quytelda Kahja <quytelda@...alin.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, jonathankim@...semi.com,
        deanahn@...semi.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: gdm724x: hci: Changed camel-case to snake-case.

That could be the case, though I'm not sure where to find any specs.
Though looking through the history of this driver, it seems that some
of the variable names have been slowly changing from camel case to
snake case.

Thanks,
Quytelda Kahja

On Wed, Feb 21, 2018 at 2:45 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Wed, Feb 21, 2018 at 02:39:28AM -0800, Quytelda Kahja wrote:
>> Changed a variable name from camel to snake case to fix a coding style
>> issue.
>>
>> Signed-off-by: Quytelda Kahja <quytelda@...il.com>
>> ---
>>  drivers/staging/gdm724x/hci_packet.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h
>> index 22ce8b9477b6..f8837c7103ac 100644
>> --- a/drivers/staging/gdm724x/hci_packet.h
>> +++ b/drivers/staging/gdm724x/hci_packet.h
>> @@ -50,7 +50,7 @@ struct tlv {
>>  struct sdu_header {
>>       __dev16 cmd_evt;
>>       __dev16 len;
>> -     __dev32 dftEpsId;
>> +     __dev32 dft_eps_ID;
>
> I bet this is a part of the user space ABI or there is a specific reason
> for the name to match the spec or something so it can't be changed...
>
> regards,
> dan carpenter
>