linux-kernel - Re: [PATCH] ARM: mx35_3ds: remove unnecessary USB OTG init flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 24 Feb 2018 17:08:21 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: mx35_3ds: remove unnecessary USB OTG init flag

On Wed, Feb 21, 2018 at 11:17:43PM +0100, Martin Kaiser wrote:
> The platform-specific init function for the USB OTG port,
> mx35_3ds_otg_init(), sets the MXC_EHCI_INTERNAL_PHY flag.
> 
> This flag is applicable only to the host port, not to the OTG port. It's
> ignored by mx35_initialize_usb_hw() when the OTG port is initialized.
> 
> Remove the flag to make it clear what is actually configured.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>

We do not take any patch on legacy board files, unless it fixes some
real problem.

Shawn

> ---
>  arch/arm/mach-imx/mach-mx35_3ds.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/mach-mx35_3ds.c b/arch/arm/mach-imx/mach-mx35_3ds.c
> index 1c33a6c..f1963f2 100644
> --- a/arch/arm/mach-imx/mach-mx35_3ds.c
> +++ b/arch/arm/mach-imx/mach-mx35_3ds.c
> @@ -407,7 +407,7 @@ static void __init imx35_3ds_init_mc13892(void)
>  
>  static int mx35_3ds_otg_init(struct platform_device *pdev)
>  {
> -	return mx35_initialize_usb_hw(pdev->id, MXC_EHCI_INTERNAL_PHY);
> +	return mx35_initialize_usb_hw(pdev->id, 0);
>  }
>  
>  /* OTG config */
> -- 
> 2.1.4
>