linux-kernel - Re: [PATCH][mm-next] mm, swap: make bool enable_vma_readahead and function swap_vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 24 Feb 2018 08:52:32 +0800
From:   "Huang\, Ying" <ying.huang@...el.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][mm-next] mm, swap: make bool enable_vma_readahead and function swap_vma_readahead static

Colin King <colin.king@...onical.com> writes:

> From: Colin Ian King <colin.king@...onical.com>
>
> The bool enable_vma_readahead and function swap_vma_readahead are local
> to the source and do not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> mm/swap_state.c:41:6: warning: symbol 'enable_vma_readahead' was not
> declared. Should it be static?
> mm/swap_state.c:742:13: warning: symbol 'swap_vma_readahead' was not
> declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: "Huang, Ying" <ying.huang@...el.com>

> ---
>  mm/swap_state.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/swap_state.c b/mm/swap_state.c
> index 8dde719e973c..f3952138f01d 100644
> --- a/mm/swap_state.c
> +++ b/mm/swap_state.c
> @@ -38,7 +38,7 @@ static const struct address_space_operations swap_aops = {
>  
>  struct address_space *swapper_spaces[MAX_SWAPFILES] __read_mostly;
>  static unsigned int nr_swapper_spaces[MAX_SWAPFILES] __read_mostly;
> -bool enable_vma_readahead __read_mostly = true;
> +static bool enable_vma_readahead __read_mostly = true;
>  
>  #define SWAP_RA_WIN_SHIFT	(PAGE_SHIFT / 2)
>  #define SWAP_RA_HITS_MASK	((1UL << SWAP_RA_WIN_SHIFT) - 1)
> @@ -739,8 +739,8 @@ static void swap_ra_info(struct vm_fault *vmf,
>  	pte_unmap(orig_pte);
>  }
>  
> -struct page *swap_vma_readahead(swp_entry_t fentry, gfp_t gfp_mask,
> -				    struct vm_fault *vmf)
> +static struct page *swap_vma_readahead(swp_entry_t fentry, gfp_t gfp_mask,
> +				       struct vm_fault *vmf)
>  {
>  	struct blk_plug plug;
>  	struct vm_area_struct *vma = vmf->vma;