linux-kernel - Re: [PATCH 1/2] selftests: ion: Remove some prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Feb 2018 09:54:37 -0700
From:   Shuah Khan <shuah@...nel.org>
To:     Laura Abbott <labbott@...hat.com>,
        Sumit Semwal <sumit.semwal@...aro.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Todd Kjos <tkjos@...roid.com>, dri-devel@...ts.freedesktop.org,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Liam Mark <lmark@...eaurora.org>,
        linux-kselftest@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH 1/2] selftests: ion: Remove some prints

On 02/15/2018 06:24 PM, Laura Abbott wrote:
> There's no need to print messages each time we alloc and free. Remove them.
> 
> Signed-off-by: Laura Abbott <labbott@...hat.com>
> ---
>  tools/testing/selftests/android/ion/ionutils.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/android/ion/ionutils.c b/tools/testing/selftests/android/ion/ionutils.c
> index ce69c14f51fa..7d1d37c4ef6a 100644
> --- a/tools/testing/selftests/android/ion/ionutils.c
> +++ b/tools/testing/selftests/android/ion/ionutils.c
> @@ -80,11 +80,6 @@ int ion_export_buffer_fd(struct ion_buffer_info *ion_info)
>  	heap_id = MAX_HEAP_COUNT + 1;
>  	for (i = 0; i < query.cnt; i++) {
>  		if (heap_data[i].type == ion_info->heap_type) {
> -			printf("--------------------------------------\n");
> -			printf("heap type: %d\n", heap_data[i].type);
> -			printf("  heap id: %d\n", heap_data[i].heap_id);
> -			printf("heap name: %s\n", heap_data[i].name);
> -			printf("--------------------------------------\n");
>  			heap_id = heap_data[i].heap_id;
>  			break;
>  		}
> @@ -204,7 +199,6 @@ void ion_close_buffer_fd(struct ion_buffer_info *ion_info)
>  		/* Finally, close the client fd */
>  		if (ion_info->ionfd > 0)
>  			close(ion_info->ionfd);
> -		printf("<%s>: buffer release successfully....\n", __func__);
>  	}
>  }
>  
> 
Thanks Laura. I will queue this up for 4.17-rc1.

thanks,
-- Shuah