linux-kernel - Re: [PATCHv5 2/5] ASoC: codec: cpcap: new codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Feb 2018 11:03:15 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Lee Jones <lee.jones@...aro.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCHv5 2/5] ASoC: codec: cpcap: new codec

On Fri, Feb 23, 2018 at 09:02:51PM +0100, Sebastian Reichel wrote:

> +	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> +	case SND_SOC_DAIFMT_I2S:
> +		val |= BIT(CPCAP_BIT_ST_DIG_AUD_FS0);
> +		val |= BIT(CPCAP_BIT_ST_DIG_AUD_FS1);
> +		break;
> +	default:
> +		/* 01 - 4 slots network mode */
> +		val |= BIT(CPCAP_BIT_ST_DIG_AUD_FS0);
> +		val &= ~BIT(CPCAP_BIT_ST_DIG_AUD_FS1);
> +		/* L on slot 1 */
> +		val |= BIT(CPCAP_BIT_ST_L_TIMESLOT0);
> +		break;
> +	}

The default case here is really one specific mode, it looks like it's
either DSP_A or DSP_B.  Most likely DSP_A but you should check.
Otherwise this looks good so I'll apply it, please send a followup patch
fixing this to match only the specific mode that's actually supported.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)