linux-kernel - Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Feb 2018 12:28:06 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Jaehoon Chung <jh80.chung@...sung.com>
Cc:     Shawn Lin <shawn.lin@...k-chips.com>,
        Alexey Roslyakov <alexey.roslyakov@...il.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

On 23 February 2018 at 07:30, Jaehoon Chung <jh80.chung@...sung.com> wrote:
> On 02/23/2018 10:40 AM, Shawn Lin wrote:
>> Hi Alexey,
>>
>> On 2018/2/23 3:45, Alexey Roslyakov wrote:
>>> cur_slot and num_slots has been removed from struct dw_mci in 42f989c002f2.
>>> Unfortunately, inline documentation was not updated so far.
>>>
>>> Fix @lock field documentation in Locking section.
>>> Move @mrq field of struct dw_mci_slot mention closer to it
>>> description, so no one could miss this slightest detail.
>>>
>>> Couple of code style fixes as a bonus.
>>>
>>
>> Thanks for updating these.
>>
>> Reviewed-by: Shawn Lin <shawn.lin@...k-chips.com>
>
> Thanks! Will apply this with Shawn's Reveiwed-by tag.

Dear Jaehoon, I picked this up for next and by adding your ack. Tell
me if you have objections!

[...]

Thanks and kind regards
Uffe