linux-kernel - Re: [PATCH 1/1] x86: Fix Intel Edison module stuck reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Feb 2018 17:44:38 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sebastian Panceac <sebastian@...in.io>
Cc:     x86@...nel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] x86: Fix Intel Edison module stuck reboot

On Tue, Feb 27, 2018 at 12:07 PM, Sebastian Panceac <sebastian@...in.io> wrote:
> Hi Andy,

Thanks for an update! My comments below.

> I fixed the commit description according to your suggestions and used git send-email.
>
> Regards!

Changelog, which is effectively above paragraph, should go after --- line below.

Version of the patch should be increased (this one is v2 so far).

You should include all maintainers and designated reviewers of the
code in question.
get_maintainer.pl script (in scripts/) will help you.

So, please resend taking into consideration all above.

> When powering Intel Edison module with 3.3V,
> the "reboot" command makes the module stuck.
> If the module is powered at a greater voltage,
> like 4.4V(as the Edison Mini Breakout board does), reboot works OK.

This looks a bit shorter than we have room for. I mean, 72 characters
per line is pretty much OK.

Also, don't miss a space before (.

> This patch copies the behaviour from the official Intel Edison BSP,
> where "IPCMSG_COLD_RESET" message
> was sent to SCU by default at reboot time.
>
> In the official BSP, sending the "IPCMSG_COLD_BOOT" message instead
> of "IPCMSG_COLD_RESET" was possible,
> by using a kernel command line parameter.
>
> Signed-off-by: Sebastian Panceac <sebastian@...in.io>
> ---

...changelog goes here...

>  arch/x86/platform/intel-mid/intel-mid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

-- 
With Best Regards,
Andy Shevchenko