linux-kernel - Re: [PATCH] mei: remove dev_err message on an unsupported ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Feb 2018 19:10:05 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Winkler, Tomas" <tomas.winkler@...el.com>
Cc:     Colin King <colin.king@...onical.com>,
        Arnd Bergmann <arnd@...db.de>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mei: remove dev_err message on an unsupported ioctl

On Tue, Feb 27, 2018 at 05:26:22PM +0000, Winkler, Tomas wrote:
> > 
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > Currently the driver spams the kernel log on unsupported ioctls which is
> > unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this anyway.
> > I suspect this was originally for debugging purposes but it really is not
> > required so remove it.
> >
> 
> This is rather strange as most of the legimit applications are using one IOCTL from kernel 3.0
> Do you have any reference where this call is originated from, frankly this is the first time I got such complain.
> 
> In any case it would be maybe better to change it a warn once call.

Just drop the message, it should not be this easy for userspace to spam
the kernel log.  The patch looks fine to me.

thanks,

greg k-h