linux-kernel - Re: mailbox: return error in mbox_request_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Mar 2018 13:51:10 +0000
From:   Fabien DESSENNE <fabien.dessenne@...com>
To:     Jassi Brar <jassisinghbrar@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Loic PALLARDY <loic.pallardy@...com>,
        Arnaud POULIQUEN <arnaud.pouliquen@...com>,
        "Ludovic BARRE" <ludovic.barre@...com>
Subject: Re: mailbox: return error in mbox_request_channel_byname

oops! you can forget this patch, the original implementation is correct

BR

Fabien


On 01/03/18 11:16, Fabien DESSENNE wrote:
> If 'name' is not found in the "mbox-names" list, return an error
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@...com>
> ---
>   drivers/mailbox/mailbox.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
> index 674b35f..a31970a 100644
> --- a/drivers/mailbox/mailbox.c
> +++ b/drivers/mailbox/mailbox.c
> @@ -391,11 +391,12 @@ struct mbox_chan *mbox_request_channel_byname(struct mbox_client *cl,
>   
>   	of_property_for_each_string(np, "mbox-names", prop, mbox_name) {
>   		if (!strncmp(name, mbox_name, strlen(name)))
> -			break;
> +			return mbox_request_channel(cl, index);
>   		index++;
>   	}
>   
> -	return mbox_request_channel(cl, index);
> +	dev_err(cl->dev, "%s() mbox %s not found\n", __func__, name);
> +	return ERR_PTR(-EINVAL);
>   }
>   EXPORT_SYMBOL_GPL(mbox_request_channel_byname);
>