linux-kernel - Re: [PATCH] selftests: memory-hotplug: silence test command echo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Mar 2018 07:41:21 -0700
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     Shuah Khan <shuah@...nel.org>, lyang0 <lei.yang@...driver.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, linux-kernel@...r.kernel.org,
        Dan Rue <dan.rue@...aro.org>,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftests: memory-hotplug: silence test command echo

On 03/01/2018 02:11 AM, Naresh Kamboju wrote:
> On 14 February 2018 at 03:14, Shuah Khan <shuahkh@....samsung.com> wrote:
>> Silence the following command being printed while running test.
>>
>> ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" ||
>> echo "selftests: memory-hotplug [FAIL]"
>>
>> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
>> ---
>>  tools/testing/selftests/memory-hotplug/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
>> index 86636d207adf..183b46883875 100644
>> --- a/tools/testing/selftests/memory-hotplug/Makefile
>> +++ b/tools/testing/selftests/memory-hotplug/Makefile
>> @@ -4,7 +4,7 @@ all:
>>  include ../lib.mk
>>
>>  TEST_PROGS := mem-on-off-test.sh
>> -override RUN_TESTS := ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
>> +override RUN_TESTS := @./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
>>  override EMIT_TESTS := echo "$(RUN_TESTS)"
>>
>>  run_full_test:
> 
> The test execution broken due to this patch ?

Thanks for reporting this. I will look at this. The change probably
broke the EMIT_TESTS case.

thanks,
-- Shuah