linux-kernel - [PATCH] regmap: debugfs: Do not print warning when no device is associated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  2 Mar 2018 16:12:40 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     broonie@...nel.org
Cc:     david@...hnology.com, linux-kernel@...r.kernel.org,
        Fabio Estevam <fabio.estevam@....com>
Subject: [PATCH] regmap: debugfs: Do not print warning when no device is associated

From: Fabio Estevam <fabio.estevam@....com>

Commit 9b947a13e7f6 ("regmap: use debugfs even when no device")
allows the usage of regmap debugfs even when there is no device
associated, which causes several warnings like this:

(NULL device *): Failed to create debugfs directory

Do not print the warning in the case there is no associated device. 

Signed-off-by: Fabio Estevam <fabio.estevam@....com>
---
 drivers/base/regmap/regmap-debugfs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index 7eb512b..db6141f 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -575,7 +575,9 @@ void regmap_debugfs_init(struct regmap *map, const char *name)
 
 	map->debugfs = debugfs_create_dir(name, regmap_debugfs_root);
 	if (!map->debugfs) {
-		dev_warn(map->dev, "Failed to create debugfs directory\n");
+		if (map->dev)
+			dev_warn(map->dev,
+				 "Failed to create debugfs directory\n");
 		return;
 	}
 
-- 
2.7.4