linux-kernel - RE: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Mar 2018 09:55:43 +0000
From:   Bogdan Purcareata <bogdan.purcareata@....com>
To:     Laurentiu Tudor <laurentiu.tudor@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
CC:     "stuyoder@...il.com" <stuyoder@...il.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Nipun Gupta <nipun.gupta@....com>,
        Roy Pledge <roy.pledge@....com>,
        Horia Geantă <horia.geanta@....com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging

> -----Original Message-----
> From: Laurentiu Tudor
> Sent: Friday, March 02, 2018 11:18 AM
> To: Bogdan Purcareata <bogdan.purcareata@....com>; gregkh@...uxfoundation.org;
> Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
> Cc: stuyoder@...il.com; Ioana Ciornei <ioana.ciornei@....com>; Nipun Gupta
> <nipun.gupta@....com>; Roy Pledge <roy.pledge@....com>; Horia Geantă
> <horia.geanta@....com>; devel@...verdev.osuosl.org; linux-
> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging
> 
> Hi Bogdan,
> 
> On 03/01/2018 07:47 PM, Bogdan Purcareata wrote:
> > Move the source files out of staging into their final locations:
> > - dpbp.c goes to drivers/bus/fsl-mc/, next to the core infrastructure
> > - dpbp-cmd.h gets merged into drivers/bus/fsl-mc/fsl-mc-private.h, next
> >    to the other internally used APIs
> > - dpbp.h gets merged into include/linux/fsl/mc.h, exposing the public
> >    API
> >
> > Update references in the dpaa2-eth staging driver.
> >
> > DPBP stands for Data Path Buffer Pool - you can read more about the
> > object in Documentation/networking/dpaa2/overview.rst
> >
> > Signed-off-by: Bogdan Purcareata <bogdan.purcareata@....com>
> > ---
> >   drivers/bus/fsl-mc/Makefile                       |  1 +
> >   drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpbp.c |  4 +-
> >   drivers/bus/fsl-mc/fsl-mc-private.h               | 39 +++++++++++++++++
> >   drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h    |  2 +-
> >   drivers/staging/fsl-mc/bus/Makefile               |  3 +-
> >   drivers/staging/fsl-mc/bus/dpbp-cmd.h             | 44 -------------------
> >   drivers/staging/fsl-mc/include/dpbp.h             | 53 --------------------
> ---
> >   include/linux/fsl/mc.h                            | 42 ++++++++++++++++++
> >   8 files changed, 86 insertions(+), 102 deletions(-)
> >   rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpbp.c (98%)
> >   delete mode 100644 drivers/staging/fsl-mc/bus/dpbp-cmd.h
> >   delete mode 100644 drivers/staging/fsl-mc/include/dpbp.h
> >
> > diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
> > index 6a97f2c..da26e52 100644
> > --- a/drivers/bus/fsl-mc/Makefile
> > +++ b/drivers/bus/fsl-mc/Makefile
> > @@ -9,6 +9,7 @@ obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
> >   mc-bus-driver-objs := fsl-mc-bus.o \
> >   		      mc-sys.o \
> >   		      mc-io.o \
> > +		      dpbp.o \
> >   		      dprc.o \
> >   		      dprc-driver.o \
> >   		      fsl-mc-allocator.o \
> > diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/bus/fsl-mc/dpbp.c
> > similarity index 98%
> > rename from drivers/staging/fsl-mc/bus/dpbp.c
> > rename to drivers/bus/fsl-mc/dpbp.c
> > index 85735bb..31a360b 100644
> > --- a/drivers/staging/fsl-mc/bus/dpbp.c
> > +++ b/drivers/bus/fsl-mc/dpbp.c
> > @@ -5,9 +5,9 @@
> >    */
> >   #include <linux/kernel.h>
> >   #include <linux/fsl/mc.h>
> > -#include "../include/dpbp.h"
> > +#include "linux/fsl/mc.h"
> 
> I think we can use <> here, same comment for patch 3/3.
> 
> Other than that, the series looks ok to me so for all the patches:
> 
> Reviewed-by: Laurentiu Tudor <laurentiu.tudor@....com>

Thank you!
I will update the patchset - seeing that the cleanup one has already been applied - and will send a v2 shortly.

Best regards,
Bogdan