[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sat, 3 Mar 2018 10:34:29 -0500
From: Dennis Dalessandro <dennis.dalessandro@...el.com>
To: Julia Lawall <julia.lawall@...6.fr>,
Arushi Singhal <arushisinghal19971997@...il.com>
Cc: mike.marciniszyn@...el.com, Doug Ledford <dledford@...hat.com>,
Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH] infiniband: hw: Drop unnecessary
continue
On 3/3/2018 9:07 AM, Julia Lawall wrote:
>> diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
>> index 3990f38..1bd3b32 100644
>> --- a/drivers/infiniband/hw/qib/qib_init.c
>> +++ b/drivers/infiniband/hw/qib/qib_init.c
>> @@ -681,7 +681,6 @@ int qib_init(struct qib_devdata *dd, int reinit)
>> if (lastfail) {
>> qib_dev_err(dd,
>> "failed to allocate kernel ctxt's rcvhdrq and/or egr bufs\n");
>> - continue;
>> }
>
> Again, the braces should be dropped too.
Thanks Julia, I just noticed the same thing! :)
-Denny
Powered by blists - more mailing lists