linux-kernel - Re: [PATCH v7 02/61] radix tree: Use bottom four bits of gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 3 Mar 2018 09:09:44 -0800
From:   Matthew Wilcox <willy@...radead.org>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v7 02/61] radix tree: Use bottom four bits of gfp_t for
 flags

On Sat, Mar 03, 2018 at 07:44:36AM -0500, Jeff Layton wrote:
> > -	return root->gfp_mask & __GFP_BITS_MASK;
> > +	return root->gfp_mask & ((__GFP_BITS_MASK >> 4) << 4);
> 
> Maybe phrase this in terms of a constant like GFP_ZONEMASK here? Would
> this be more appropriate?

Yeah, that's a better idea.  This is only interim; once all radix tree users
are converted to the xarray, we stop storing GFP flags here.  So I hadn't
put much thought into it, but I'll change it.