linux-kernel - Re: [PATCH] x86/kconfig: Remove residual "no-hlt" boot parameter reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Mar 2018 08:10:21 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     "zhenwei.pi" <zhenwei.pi@...runcloud.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org, hpa@...or.com,
        mingo@...hat.com, tglx@...utronix.de
Subject: Re: [PATCH] x86/kconfig: Remove residual "no-hlt" boot parameter
 reference


* zhenwei.pi <zhenwei.pi@...runcloud.com> wrote:

> The "no-hlt" boot parameter has been removed ~5 years ago :
> 	The commit 27be457000211a6903968dfce06d5f73f051a217
> 	("x86 idle: remove 32-bit-only "no-hlt" parameter, hlt_works_ok flag")
> 
> Remove a stale reference from the documentation as well.
> 
> Signed-off-by: zhenwei.pi <zhenwei.pi@...runcloud.com>
> ---
>  arch/x86/Kconfig | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index eb7f43f..bdb17b7 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2494,19 +2494,18 @@ menuconfig APM
>  
>  	  1) make sure that you have enough swap space and that it is
>  	  enabled.
> -	  2) pass the "no-hlt" option to the kernel
> -	  3) switch on floating point emulation in the kernel and pass
> +	  2) switch on floating point emulation in the kernel and pass
>  	  the "no387" option to the kernel
> -	  4) pass the "floppy=nodma" option to the kernel
> -	  5) pass the "mem=4M" option to the kernel (thereby disabling
> +	  3) pass the "floppy=nodma" option to the kernel
> +	  4) pass the "mem=4M" option to the kernel (thereby disabling
>  	  all but the first 4 MB of RAM)
> -	  6) make sure that the CPU is not over clocked.
> -	  7) read the sig11 FAQ at <http://www.bitwizard.nl/sig11/>
> -	  8) disable the cache from your BIOS settings
> -	  9) install a fan for the video card or exchange video RAM
> -	  10) install a better fan for the CPU
> -	  11) exchange RAM chips
> -	  12) exchange the motherboard.
> +	  5) make sure that the CPU is not over clocked.
> +	  6) read the sig11 FAQ at <http://www.bitwizard.nl/sig11/>
> +	  7) disable the cache from your BIOS settings
> +	  8) install a fan for the video card or exchange video RAM
> +	  9) install a better fan for the CPU
> +	  10) exchange RAM chips
> +	  11) exchange the motherboard.

That description is stale in other ways as well (nobody uses floppies anymore), 
I'd just remove it altogether, starting with this:

                                                                If you get
          random kernel OOPSes or reboots that don't seem to be related to
          anything, try disabling/enabling this option (or disabling/enabling
          APM in your BIOS).
	  [...]

Thanks,

	Ingo