linux-kernel - Re: [PATCH AUTOSEL for 4.9 111/219] ASoc: rt5645: Add OF device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Mar 2018 10:42:03 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Sasha Levin <Alexander.Levin@...rosoft.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Javier Martinez Canillas <javier@....samsung.com>
Subject: Re: [PATCH AUTOSEL for 4.9 111/219] ASoc: rt5645: Add OF device ID
 table

On Sat, Mar 03, 2018 at 10:29:00PM +0000, Sasha Levin wrote:
> From: Javier Martinez Canillas <javier@....samsung.com>
> 
> [ Upstream commit 9ba2da5f5d18daaa365ab5426b05e16f1d114786 ]
> 
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
> 
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.

As the commit message itself says this is not fixing anything, it's
defence against future changes.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)