linux-kernel - Re: [PATCH v3] mmc: Export host capabilities to debugfs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Mar 2018 19:18:26 +0530
From:   Harish Jenny K N <harish_kandiga@...tor.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
CC:     Linus Walleij <linus.walleij@...aro.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Shawn Lin <shawn.lin@...k-chips.com>, <avri.altman@....com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Vladimir Zapolskiy <Vladimir_Zapolskiy@...tor.com>
Subject: Re: [PATCH v3] mmc: Export host capabilities to debugfs.



On Monday 05 March 2018 05:43 PM, Ulf Hansson wrote:
> On 5 March 2018 at 10:28, Harish Jenny K N <harish_kandiga@...tor.com> wrote:
>> From: Abbas Raza <Abbas_Raza@...tor.com>
>>
>> This patch exports the host capabilities to debugfs
>>
>> Signed-off-by: Abbas Raza <Abbas_Raza@...tor.com>
>> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@...tor.com>
>> Signed-off-by: Harish Jenny K N <harish_kandiga@...tor.com>
>> ---
>>
>> Changes in v3:
>> - Removed typecasting of &host->caps to (u32 *)
>>
>> Changes in v2:
>> - Changed Author
>>
>>  drivers/mmc/core/debugfs.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
>> index c51e0c0..570c9e4 100644
>> --- a/drivers/mmc/core/debugfs.c
>> +++ b/drivers/mmc/core/debugfs.c
>> @@ -289,6 +289,9 @@ void mmc_add_card_debugfs(struct mmc_card *card)
>>
>>         card->debugfs_root = root;
>>
>> +       if (!debugfs_create_x32("host_caps", S_IRUSR, root, &host->caps))
>> +               goto err;
>> +
> This isn't the correct place to created the node(s). Please move this
> to mmc_add_host_debugfs().
>
> Moreover, I suggest you export both caps and caps2 in the same change,
> there is no need to have two changes for that - and finally name the
> nodes to "caps" and "caps2".

Addressed your review findings in v4 patch.

Thanks,
Harish Jenny K N