linux-kernel - Re: [RFC PATCH 2/2] i2c: mux: pca954x: verify the device id of the pca984x chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Mar 2018 17:29:26 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Peter Rosin <peda@...ntia.se>
Cc:     Adrian Fiergolski <adrian.fiergolski@...n.ch>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 2/2] i2c: mux: pca954x: verify the device id of the
 pca984x chips

On Mon, Mar 05, 2018 at 04:55:56PM +0100, Peter Rosin wrote:
> On 2018-03-05 16:53, Wolfram Sang wrote:
> > 
> >> @@ -97,59 +98,83 @@ static const struct chip_desc chips[] = {
> >>  		.nchans = 2,
> >>  		.enable = 0x4,
> >>  		.muxtype = pca954x_ismux,
> >> +		.id = { .manufacturer_id = I2C_DEVICE_ID_NONE },
> > 
> > Can't we just leave this empty and add a NULL pointer check below when
> > testing for the device id?
> 
> Nope, it's not a pointer. I didn't think it should be, but maybe it
> should?

Nope, you are right. Thanks for the heads up!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)