linux-kernel - Re: [PATCH 2/3] mfd: rave-sp: Convert print_hex_dump() to print_hex_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 06 Mar 2018 15:09:42 +0100
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Andrey Smirnov <andrew.smirnov@...il.com>,
        Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org, cphealy@...il.com,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH 2/3] mfd: rave-sp: Convert print_hex_dump() to
 print_hex_dump_debug()

Am Montag, den 26.02.2018, 07:07 -0800 schrieb Andrey Smirnov:
> Convert print_hex_dump() to print_hex_dump_debug() to be able to
> leverage CONFIG_DYNAMIC_DEBUG.
> 
> Cc: linux-kernel@...r.kernel.org
> Cc: cphealy@...il.com
> Cc: Lucas Stach <l.stach@...gutronix.de>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>

Reviewed-by: Lucas Stach <l.stach@...gutronix.de>

> ---
>  drivers/mfd/rave-sp.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
> index 9e4c83ff2aec..cec1e309b31f 100644
> --- a/drivers/mfd/rave-sp.c
> +++ b/drivers/mfd/rave-sp.c
> @@ -311,8 +311,8 @@ static int rave_sp_write(struct rave_sp *sp,
> const u8 *data, u8 data_size)
>  
>  	length = dest - frame;
>  
> -	print_hex_dump(KERN_DEBUG, "rave-sp tx: ", DUMP_PREFIX_NONE,
> -		       16, 1, frame, length, false);
> +	print_hex_dump_debug("rave-sp tx: ", DUMP_PREFIX_NONE,
> +			     16, 1, frame, length, false);
>  
>  	return serdev_device_write(sp->serdev, frame, length, HZ);
>  }
> @@ -453,8 +453,8 @@ static void rave_sp_receive_frame(struct rave_sp
> *sp,
>  	struct device *dev           = &sp->serdev->dev;
>  	u8 crc_calculated[checksum_length];
>  
> -	print_hex_dump(KERN_DEBUG, "rave-sp rx: ", DUMP_PREFIX_NONE,
> -		       16, 1, data, length, false);
> +	print_hex_dump_debug("rave-sp rx: ", DUMP_PREFIX_NONE,
> +			     16, 1, data, length, false);
>  
>  	if (unlikely(length <= checksum_length)) {
>  		dev_warn(dev, "Dropping short frame\n");