linux-kernel - Re: [PATCH v2] cxgb3: remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 07 Mar 2018 15:56:14 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     gustavo@...eddedor.com
Cc:     santosh@...lsio.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, garsilva@...eddedor.com
Subject: Re: [PATCH v2] cxgb3: remove VLA usage

From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Date: Wed, 7 Mar 2018 12:03:33 -0600

> Remove VLA usage and change the 'len' argument to a u8 and use a 256
> byte buffer on the stack. Notice that these lengths are limited by the
> encoding field in the VPD structure, which is a u8 [1].
> 
> [1] https://marc.info/?l=linux-netdev&m=152044354814024&w=2
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
> Changes in v2:
>  - Update the code as suggested by David Miller.
>  - Update changelog based on David's comments.
>  - Update subject.

Applied to net-next, thanks.