linux-kernel - MIPS DT W=1 warnings (was Re: [PATCH v5 2/5] MIPS: mscc: add ocelot dtsi)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Mar 2018 21:49:26 +0000
From:   James Hogan <jhogan@...nel.org>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Allan Nielsen <Allan.Nielsen@...rosemi.com>,
        Linux-MIPS <linux-mips@...ux-mips.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org,
        Álvaro Fernández Rojas <noltari@...il.com>,
        Kevin Cernekee <cernekee@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: MIPS DT W=1 warnings (was Re: [PATCH v5 2/5] MIPS: mscc: add ocelot
 dtsi)

Hi Rob,

On Wed, Mar 07, 2018 at 10:08:28AM -0600, Rob Herring wrote:
> Please compile with W=1 and fix any issues like this one which is a
> unit-address without a reg property. Drop the unit-address.

I was just giving the BMIPS W=1 DT warnings a look, and a few look
spurious. I'd value your opinion on their legitimacy (its hard to care
about W=1 if spurious or seemingly pedantic warnings are going to be
common). e.g.

1)
arch/mips/boot/dts/brcm/bcm9ejtagprb.dtb: Warning (unit_address_vs_reg): Node /ubus/syscon-reboot@...00068 has a unit name, but no reg property          

due to:

periph_cntl: syscon@...8c000 {
	compatible = "syscon";
	reg = <0xfff8c000 0xc>;
	native-endian;
};

reboot: syscon-reboot@...8c008 {
	compatible = "syscon-reboot";
	regmap = <&periph_cntl>;
	offset = <0x8>;
	mask = <0x1>;
};

That doesn't seem to take regmap into account. Would you strictly drop
the unit-address in this case, or is there a way the DT compiler can be
fixed (i presume offset and mask are binding specific, so the best it
could do is probably to allow the unit-address due to the regmap without
checking the actual address)?

2)
arch/mips/boot/dts/brcm/bcm9ejtagprb.dtb: Warning (simple_bus_reg): Node /ubus/syscon-reboot@...00068 missing or empty reg/ranges property

Same code as above. Should syscon-reboot be outside of the simple-bus
that both nodes are in, or is it fine there? There's a similar warning
from a DTS which has a syscon property instead of regmap.

3)
arch/mips/boot/dts/brcm/bcm97425svmb.dtb: Warning (simple_bus_reg): Node /rdb@...00000/spi@...000 simple-bus unit address format error, expected "419920"

qspi: spi@...000 {
	#address-cells = <0x1>;
	#size-cells = <0x0>;
	compatible = "brcm,spi-bcm-qspi",
		     "brcm,spi-brcmstb-qspi";
	clocks = <&upg_clk>;
	reg = <0x419920 0x4 0x41c200 0x188 0x41c000 0x50>;
	reg-names = "cs_reg", "hif_mspi", "bspi";
	...

Well 41c000 is one of the reg entries, just not the first. I presume
bspi is the "main" one, perhaps that should come first since we have
reg-names, but even that could potentially confuse driver code if it
didn't find reg resources by name (in this case it does appear to, so
perhaps that would fine)?

Thanks
James

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)