linux-kernel - Re: [PATCH 02/11] Staging: iio: accel: Add a blank space before returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Mar 2018 20:32:06 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Himanshu Jha <himanshujha199640@...il.com>
Cc:     lars@...afoo.de, Michael.Hennerich@...log.com, knaack.h@....de,
        pmeerw@...erw.net, gregkh@...uxfoundation.org,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, daniel.baluta@...il.com
Subject: Re: [PATCH 02/11] Staging: iio: accel: Add a blank space before
 returns

On Mon,  5 Mar 2018 13:19:21 +0530
Himanshu Jha <himanshujha199640@...il.com> wrote:

> Adding a blank space before/after some returns improves readability.
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@...il.com>
Applied - patch title adjusted.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/accel/adis16201.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c
> index 0f6a204..0fae8aa 100644
> --- a/drivers/staging/iio/accel/adis16201.c
> +++ b/drivers/staging/iio/accel/adis16201.c
> @@ -232,6 +232,7 @@ static int adis16201_read_raw(struct iio_dev *indio_dev,
>  		*val = val16;
>  		return IIO_VAL_INT;
>  	}
> +
>  	return -EINVAL;
>  }
>  
> @@ -262,6 +263,7 @@ static int adis16201_write_raw(struct iio_dev *indio_dev,
>  		addr = adis16201_addresses[chan->scan_index];
>  		return adis_write_reg_16(st, addr, val16);
>  	}
> +
>  	return -EINVAL;
>  }
>  
> @@ -336,6 +338,7 @@ static int adis16201_probe(struct spi_device *spi)
>  	ret = adis_init(st, indio_dev, spi, &adis16201_data);
>  	if (ret)
>  		return ret;
> +
>  	ret = adis_setup_buffer_and_trigger(st, indio_dev, NULL);
>  	if (ret)
>  		return ret;
> @@ -348,6 +351,7 @@ static int adis16201_probe(struct spi_device *spi)
>  	ret = iio_device_register(indio_dev);
>  	if (ret < 0)
>  		goto error_cleanup_buffer_trigger;
> +
>  	return 0;
>  
>  error_cleanup_buffer_trigger: