linux-kernel - Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Mar 2018 16:11:35 +0100
From:   Lothar Waßmann <LW@...O-electronics.de>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth

Hi,

On Tue,  6 Mar 2018 22:58:19 +0100 Martin Kaiser wrote:
> According to the i.MX25 reference manuals, each SSI has four FIFOs. All
> of those FIFOs can store up to 15 entries.
> 
> The fsl_ssi driver's internal default for the FIFO depth in 8. Set our
> non-default FIFO depth explicitly in the Device Tree.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>  arch/arm/boot/dts/imx25.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index 9725705..cf70df2 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -269,6 +269,7 @@
>  				dmas = <&sdma 24 1 0>,
>  				       <&sdma 25 1 0>;
>  				dma-names = "rx", "tx";
> +				fsl,fifo-depth = <15>;
>  				status = "disabled";
>  			};
>  
> @@ -329,6 +330,7 @@
>  				dmas = <&sdma 28 1 0>,
>  				       <&sdma 29 1 0>;
>  				dma-names = "rx", "tx";
> +				fsl,fifo-depth = <15>;
>  				status = "disabled";
>  			};
>  
You are changing the global .dtsi file. Did you test this change with
all devices that are affected by it?


Lothar Waßmann