linux-kernel - Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Mar 2018 18:41:04 -0800
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, broonie@...nel.org,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux MM <linux-mm@...ck.org>, linux-next@...r.kernel.org,
        Michal Hocko <mhocko@...e.cz>, mm-commits@...r.kernel.org,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

On Wed, Mar 7, 2018 at 6:34 PM, Shakeel Butt <shakeelb@...gle.com> wrote:
> On Wed, Mar 7, 2018 at 6:23 PM, Randy Dunlap <rdunlap@...radead.org> wrote:
>> On 03/07/2018 06:20 PM, Randy Dunlap wrote:
>>> On 03/07/2018 04:20 PM, akpm@...ux-foundation.org wrote:
>>>> The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
>>>>
>>>>    http://www.ozlabs.org/~akpm/mmotm/
>>>>
>>>> mmotm-readme.txt says
>>>>
>>>> README for mm-of-the-moment:
>>>>
>>>> http://www.ozlabs.org/~akpm/mmotm/
>>>>
>>>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>>>> more than once a week.
>>>
>>> UML on i386 and/or x86_64:
>>>
>>> defconfig, CONFIG_MEMCG is not set:
>>>
>>> ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
>>> ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
>>>    css_put(&group->memcg->css);
>>>                         ^
>>>
>>> From: Shakeel Butt <shakeelb@...gle.com>
>>> Subject: fs: fsnotify: account fsnotify metadata to kmemcg
>>
>>
>>
>> or x86 any time that CONFIG_MEMCG is not enabled.
>>
>>
>
> Sorry about that. Replacing this with mem_cgroup_put(group->memcg)
> should solve the issue on the mm tree.

Andrew, do you want me to extract mem_cgroup_put() API from Roman's
patches as a separate patch?