linux-kernel - Re: [PATCH v3 09/22] arm64: capabilities: Split the processing of errata work arounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Mar 2018 12:24:40 +0000
From:   Suzuki K Poulose <Suzuki.Poulose@....com>
To:     Dave Martin <Dave.Martin@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, mark.rutland@....com,
        ckadabi@...eaurora.org, ard.biesheuvel@...aro.org,
        marc.zyngier@....com, catalin.marinas@....com, will.deacon@....com,
        linux-kernel@...r.kernel.org, jnair@...iumnetworks.com,
        robin.murphy@....com
Subject: Re: [PATCH v3 09/22] arm64: capabilities: Split the processing of
 errata work arounds

On 09/02/18 18:18, Dave Martin wrote:
> On Fri, Feb 09, 2018 at 05:54:48PM +0000, Suzuki K Poulose wrote:
>> Right now we run through the errata workarounds check on all boot
>> active CPUs, with SCOPE_ALL. This doesn't help with detecting the
>> errata's with a SYSTEM_SCOPE. While nobody uses it, let us clean
>> this up in preparation for merging capability handling.
> 
> errata; and SCOPE_SYSTEM (if I'm being pedantic)
> 
> To make it clearer this this is adding support for new behaviour rather
> than changing old behaviour, perhaps change "This doesn't help ...
> While nobody uses it ..." to something like:
> 
> "This wouldn't help for detecting erratum workarounds with SCOPE_SYSTEM.
> There are none yet, but we plan to introduce some: let us clean this up
> so that such workarounds can be detected and enabled correctly."

Fixed

>>
>> So, we run the checks with SCOPE_LOCAL_CPU on all CPUs and SCOPE_SYSTEM
>> checks are run only once after all the boot time CPUs are active.
>>
>> Cc: Dave Martin <dave.martin@....com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
> 
> Otherwise,
> 
> Reviewed-by: Dave Martin <Dave.Martin@....com>

Thanks
Suzuki