linux-kernel - Re: [PATCH v2 0/6] Add mmc support for STM32F7 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Mar 2018 13:51:23 +0100
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Lee Jones <lee.jones@...aro.org>,
        Patrice CHOTARD <patrice.chotard@...com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>
Subject: Re: [PATCH v2 0/6] Add mmc support for STM32F7 boards

Hi Lee

On 03/07/2018 11:57 AM, Lee Jones wrote:
> On Wed, 07 Mar 2018, Patrice CHOTARD wrote:
> 
>> Hi Lee
>>
>> On 03/07/2018 09:35 AM, Lee Jones wrote:
>>> On Mon, 05 Mar 2018, Alexandre Torgue wrote:
>>>
>>>> Hi Patrice,
>>>>
>>>> On 03/01/2018 11:53 AM, patrice.chotard@...com wrote:
>>>>> From: Patrice Chotard <patrice.chotard@...com>
>>>>>
>>>>> This series adds :
>>>>>     _ SDIO pins definition for STM32F7 SoCs family
>>>>>     _ add sdio1 DT entry for STM32F746 Discovery board
>>>>>     _ add sdio1 DT entry for STM32F746 Evaluation board
>>>>>     _ add sdio1 DT entry for STM32F769 Discovery board
>>>>>     _ add SDMMC2 entry in stm32f7-rcc.h
>>>>>     _ replace sdio2 hard coded value in stm32f746.dtsi
>>>>>
>>>>> v2: _ rename sdio_pins / sdio_od_pins to sdio_pins_a / sdio_od_pins_a
>>>>>          and update board dts files accordingly.
>>>>>
>>>>>
>>>>> Patrice Chotard (6):
>>>>>      ARM: dts: stm32: Add sdio pins definition for stm32f7
>>>>>      ARM: dts: stm32: Enable sdio1 for stm32f746-disco
>>>>>      ARM: dts: stm32: Enable sdio1 for stm32f746-eval
>>>>>      ARM: dts: stm32: Enable sdio1 for stm32f769-disco
>>>>>      dt-bindings: mfd: Add STM32F7 SDMMC2 rcc entry
>>>>>      ARM: dts: stm32: Fix sdio2 rcc hard coded value
>>>>>
>>>>>     arch/arm/boot/dts/stm32746g-eval.dts   | 17 ++++++++++
>>>>>     arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 62 ++++++++++++++++++++++++++++++++++
>>>>>     arch/arm/boot/dts/stm32f746-disco.dts  | 19 +++++++++++
>>>>>     arch/arm/boot/dts/stm32f746.dtsi       |  2 +-
>>>>>     arch/arm/boot/dts/stm32f769-disco.dts  | 19 +++++++++++
>>>>>     include/dt-bindings/mfd/stm32f7-rcc.h  |  1 +
>>>>>     6 files changed, 119 insertions(+), 1 deletion(-)
>>>>>
>>>> Series applied on stm32-next.
>>>
>>> Even the MFD patch?
>>>
>>
>> Yes, the MFD part has been taken by Alex.
> 
> You should really wait for all of the appropriate Acks.  This helps to
> avoid possible merge conflicts when Linus starts pulling branches
> during the merge-window.

I took it maybe too quickly. Sorry for that. As it was only a new define 
without impact in mfd driver I didn't wait for an "ack". But yes, it is 
not very "fair" :$. I agree that we need to wait for relevant ack.

cheers
alex

> 
> As it happens, I do not think Alex's tree and MFD will conflict this
> time, but it's something to bear in mind in the future.
> 
> Please add my:
> 
>    Acked-by: Lee Jones <lee.jones@...aro.org>
> 
> ... to the patch.
>