| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Mar 2018 12:56:28 +0000
From: Joao Martins <joao.m.martins@...cle.com>
To: Boris Ostrovsky <boris.ostrovsky@...cle.com>
Cc: linux-kernel@...r.kernel.org, Juergen Gross <jgross@...e.com>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Robert Moore <robert.moore@...el.com>,
linux-acpi@...r.kernel.org, xen-devel@...ts.xenproject.org,
Len Brown <lenb@...nel.org>,
Erik Schmauss <erik.schmauss@...el.com>, devel@...ica.org
Subject: Re: [Xen-devel] [PATCH v2] xen/acpi: upload _PSD info for non Dom0
CPUs too
On 03/08/2018 10:33 PM, Boris Ostrovsky wrote:
> On 03/08/2018 05:57 AM, Joao Martins wrote:
>
>> @@ -372,6 +376,15 @@ read_acpi_id(acpi_handle handle, u32 lvl, void *context, void **rv)
>>
>> pr_debug("ACPI CPU%u w/ PBLK:0x%lx\n", acpi_id, (unsigned long)pblk);
>>
>> + /* It has P-state dependencies */
>> + if (!acpi_processor_get_psd(handle, &acpi_psd[acpi_id])) {
>> + __set_bit(acpi_id, acpi_id_psd_present);
>> +
>> + pr_debug("ACPI CPU%u w/ PST:coord_type = %llu domain = %llu\n",
>> + acpi_id, acpi_psd[acpi_id].coord_type,
>> + acpi_psd[acpi_id].domain);
>> + }
>
>
> I should have noticed this earlier, but do you really need
> acpi_id_psd_present? Can you just go by acpi_psd[i] != NULL?
>
Oh yes! I was trying to be consistent with the rest of the module, but we surely
don't need that array of longs. Will respin after testing.
> Sorry for missing it in the first patch.
>
Thanks for the feedback!
> -boris
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...ts.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
>
Powered by blists - more mailing lists