linux-kernel - Re: [PATCH] staging: vchiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Mar 2018 10:44:21 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Eric Anholt <eric@...olt.net>, "Tobin C. Harding" <me@...in.cc>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Kernel Hardening <kernel-hardening@...ts.openwall.com>,
        LKML <linux-kernel@...r.kernel.org>,
        driverdev-devel@...uxdriverproject.org,
        Tycho Andersen <tycho@...ho.ws>
Subject: Re: [PATCH] staging: vchiq_arm: Clear VLA warning

On Fri, Mar 9, 2018 at 10:35 AM, Kees Cook <keescook@...omium.org> wrote:
>
> I think you mean ARRAY_SIZE(service_data) ? In that case, yeah, it
> seems like a raw "64" for the array size can be used instead.

I think 64 is much too big anyway. That's 768 bytes of stack data that
is used to check stuff deep in some transfer call chain.

So that code is broken from a stack usage model anyway. If it's just a
"random big number", then cut it down in size.

I don't know. The code was imported in 2013, and has seen very little
change since. I'm not sure how many users it has. But while changing
this, just do the stack size limitation at the same time.

              Linus