linux-kernel - Re: [RFC PATCH 13/35] syscalls: do not call sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 11 Mar 2018 15:20:01 +0000
From:   Andy Lutomirski <luto@...nel.org>
To:     Dominik Brodowski <linux@...inikbrodowski.net>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andrew Lutomirski <luto@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, X86 ML <x86@...nel.org>
Subject: Re: [RFC PATCH 13/35] syscalls: do not call sys_ioperm() within the kernel

On Sun, Mar 11, 2018 at 10:55 AM, Dominik Brodowski
<linux@...inikbrodowski.net> wrote:
> While at it, use SYSCALL_DEFINE3() instead of a hand-crafted syscall
> definition.

Great!

>  static void complete_change_console(struct vc_data *vc);
> @@ -420,12 +420,12 @@ int vt_ioctl(struct tty_struct *tty,
>                         ret = -EINVAL;
>                         break;
>                 }
> -               ret = sys_ioperm(arg, 1, (cmd == KDADDIO)) ? -ENXIO : 0;
> +               ret = ksys_ioperm(arg, 1, (cmd == KDADDIO)) ? -ENXIO : 0;
>                 break;
>
>         case KDENABIO:
>         case KDDISABIO:
> -               ret = sys_ioperm(GPFIRST, GPNUM,
> +               ret = ksys_ioperm(GPFIRST, GPNUM,
>                                   (cmd == KDENABIO)) ? -ENXIO : 0;
>                 break;
>  #endif

I wonder if we can just delete this code.