linux-kernel - [PATCH] drm: zte: Fix an error handling path in 'zx_crtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 11 Mar 2018 23:32:03 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     shawnguo@...nel.org, airlied@...ux.ie
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: [PATCH] drm: zte: Fix an error handling path in 'zx_crtc_bind()'

'ret' is known to be 0 at this point. It must be updated by the value
returned by 'clk_prepare_enable()'.

Fixes: 0a886f59528a ("drm: zte: add initial vou drm driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
---
 drivers/gpu/drm/zte/zx_vou.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/zte/zx_vou.c b/drivers/gpu/drm/zte/zx_vou.c
index 7491813131f3..3351b258ed7a 100644
--- a/drivers/gpu/drm/zte/zx_vou.c
+++ b/drivers/gpu/drm/zte/zx_vou.c
@@ -838,7 +838,7 @@ static int zx_crtc_bind(struct device *dev, struct device *master, void *data)
 		return ret;
 	}
 
-	clk_prepare_enable(vou->ppu_clk);
+	ret = clk_prepare_enable(vou->ppu_clk);
 	if (ret) {
 		DRM_DEV_ERROR(dev, "failed to enable ppu_clk: %d\n", ret);
 		goto disable_axi_clk;
-- 
2.14.1


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus